Refactor polyglot validation sample layout by sebastienros · Pull Request #15650 · microsoft/aspire

sebastienros · 2026-03-27T18:01:49Z

Description

Refactors the TypeScript, Python, and Java polyglot validation samples into shared per-language roots under tests/Polyglot, with one AppHost file per integration.

This also updates the Aspire CLI polyglot AppHost detection so suffixed filenames like aspire.hosting.sqlserver.apphost.ts are recognized, and adjusts the Java runtime/validation flow to compile renamed AppHosts through a temporary AppHost.java.

The CI validation scripts now target the new tests/Polyglot/<Language> layout and restore each sample with --apphost against a shared aspire.config.json per language.

Fixes # (issue)

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire.dev issue:
    - New issue
- No

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-27T18:03:23Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15650

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15650"

Copilot

Pull request overview

Refactors the polyglot validation samples into a shared tests/Polyglot/<Language> layout and updates CI validation scripts to validate per-language AppHosts via aspire restore --apphost.

Changes:

Moves validation inputs from playground/polyglot/** into tests/Polyglot/** (per-language roots; one AppHost file per integration).
Updates TypeScript/Python/Java CI validation scripts to enumerate *.apphost.* files and restore/typecheck/compile each one.
Adjusts Java validation compilation to copy suffixed AppHost filenames into a temporary AppHost.java before javac.

Reviewed changes

Copilot reviewed 256 out of 595 changed files in this pull request and generated 6 comments.

File	Description
`.github/workflows/polyglot-validation/test-typescript-playground.sh`	Switches validation to `tests/Polyglot/TypeScript`, restores per AppHost, and type-checks via a generated temporary tsconfig.
`.github/workflows/polyglot-validation/test-python-playground.sh`	Switches validation to `tests/Polyglot/Python`, restores per AppHost, and byte-compiles the selected AppHost plus generated modules.
`.github/workflows/polyglot-validation/test-java-playground.sh`	Switches validation to `tests/Polyglot/Java`, restores per AppHost, and compiles by copying the selected AppHost into a temporary `AppHost.java`.
`playground/polyglot/**`	Removes legacy per-sample configs/run settings now superseded by the shared `tests/Polyglot/<Language>` layout.

Files not reviewed (17)

playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppConfiguration/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppContainers/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.AppService/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ApplicationInsights/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.CognitiveServices/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ContainerRegistry/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.CosmosDB/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.EventHubs/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Functions/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.KeyVault/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Kusto/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.OperationalInsights/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.PostgreSQL/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Redis/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.Search/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/package-lock.json: Language not supported
playground/polyglot/TypeScript/Aspire.Hosting.Azure.SignalR/ValidationAppHost/package-lock.json: Language not supported

.github/workflows/polyglot-validation/test-typescript-playground.sh

.github/workflows/polyglot-validation/test-java-playground.sh

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

src/Aspire.Cli/Projects/DefaultLanguageDiscovery.cs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…-layout

JamesNK

Main concern: several aspire.config.json files are missing secondary package dependencies that the old per-language configs had. See inline comment for the full list.

tests/PolyglotAppHosts/Aspire.Hosting.Azure.CosmosDB/Python/aspire.config.json

src/Aspire.Cli/Projects/LanguageDetectionPatternMatcher.cs

src/Aspire.Hosting.CodeGeneration.Java/JavaLanguageSupport.cs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

src/Aspire.Cli/Projects/LanguageDetectionPatternMatcher.cs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros · 2026-04-01T15:11:52Z

In response to review 4041128520: accepted. The moved per-language configs had dropped several secondary package references, so I restored the missing ones across the affected Java/Python/TypeScript aspire.config.json files and reran focused polyglot restore/compile checks. Aspire.Hosting.Redis and Aspire.Hosting.Azure.AppContainers were already present, so those two did not need changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros · 2026-04-01T15:17:34Z

Follow-up on review 4041128520: after verifying the current moved Aspire.Hosting fixtures, Aspire.Hosting.Testing and Aspire.Hosting.Yarp are not exercised, so I kept those out. The config fixes are limited to the secondary packages used by the moved apphosts, and I reran focused restore/compile validation after trimming Aspire.Hosting back down.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2026-04-01T16:42:35Z

.gitignore


 # Required for polyglot apps
-!playground/polyglot/**/.aspire/
+!tests/PolyglotAppHosts/**/.aspire/


Do we even have this folder anymore? CAn it be removed

github-actions · 2026-04-01T16:44:40Z

🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit b1fb150)

View recordings

Test	Recording
AddPackageInteractiveWhileAppHostRunningDetached	▶️ View Recording
AddPackageWhileAppHostRunningDetached	▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect	▶️ View Recording
AgentInitCommand_DefaultSelection_InstallsSkillOnly	▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig	▶️ View Recording
AspireAddPackageVersionToDirectoryPackagesProps	▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps	▶️ View Recording
Banner_DisplayedOnFirstRun	▶️ View Recording
Banner_DisplayedWithExplicitFlag	▶️ View Recording
Banner_NotDisplayedWithNoLogoFlag	▶️ View Recording
CertificatesClean_RemovesCertificates	▶️ View Recording
CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate	▶️ View Recording
CertificatesTrust_WithUntrustedCert_TrustsCertificate	▶️ View Recording
ConfigSetGet_CreatesNestedJsonFormat	▶️ View Recording
CreateAndRunAspireStarterProject	▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle	▶️ View Recording
CreateAndRunEmptyAppHostProject	▶️ View Recording
CreateAndRunJavaEmptyAppHostProject	▶️ View Recording
CreateAndRunJsReactProject	▶️ View Recording
CreateAndRunPythonReactProject	▶️ View Recording
CreateAndRunTypeScriptEmptyAppHostProject	▶️ View Recording
CreateAndRunTypeScriptStarterProject	▶️ View Recording
CreateJavaAppHostWithViteApp	▶️ View Recording
CreateStartAndStopAspireProject	▶️ View Recording
CreateTypeScriptAppHostWithViteApp	▶️ View Recording
DescribeCommandResolvesReplicaNames	▶️ View Recording
DescribeCommandShowsRunningResources	▶️ View Recording
DetachFormatJsonProducesValidJson	▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig	▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted	▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	▶️ View Recording
GlobalMigration_HandlesCommentsAndTrailingCommas	▶️ View Recording
GlobalMigration_HandlesMalformedLegacyJson	▶️ View Recording
GlobalMigration_PreservesAllValueTypes	▶️ View Recording
GlobalMigration_SkipsWhenNewConfigExists	▶️ View Recording
GlobalSettings_MigratedFromLegacyFormat	▶️ View Recording
InvalidAppHostPathWithComments_IsHealedOnRun	▶️ View Recording
LogsCommandShowsResourceLogs	▶️ View Recording
PsCommandListsRunningAppHost	▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout	▶️ View Recording
PublishWithDockerComposeServiceCallbackSucceeds	▶️ View Recording
RestoreGeneratesSdkFiles	▶️ View Recording
RunWithMissingAwaitShowsHelpfulError	▶️ View Recording
SecretCrudOnDotNetAppHost	▶️ View Recording
SecretCrudOnTypeScriptAppHost	▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels	▶️ View Recording
StopAllAppHostsFromAppHostDirectory	▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory	▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError	▶️ View Recording
StopNonInteractiveSingleAppHost	▶️ View Recording
StopWithNoRunningAppHostExitsSuccessfully	▶️ View Recording
TypeScriptAppHostWithProjectReferenceIntegration	▶️ View Recording

_{📹 Recordings uploaded automatically from CI run #23858406344}

Refactor polyglot validation sample layout

ea2c8b2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros marked this pull request as ready for review March 27, 2026 18:34

sebastienros requested review from JamesNK, davidfowl and mitchdenny as code owners March 27, 2026 18:34

Copilot AI review requested due to automatic review settings March 27, 2026 18:34

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Fix polyglot root hosting samples

0c32bfe

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros requested a review from eerhardt March 27, 2026 18:59

github-actions bot mentioned this pull request Mar 27, 2026

[pull requests] Review required #13834

Open

sebastienros commented Mar 30, 2026

View reviewed changes

src/Aspire.Cli/Projects/DefaultLanguageDiscovery.cs Outdated Show resolved Hide resolved

eerhardt approved these changes Mar 30, 2026

View reviewed changes

sebastienros and others added 2 commits March 31, 2026 16:51

Refactor polyglot apphost test layout

7df55e6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into sebros/polyglot-tests…

d394f29

…-layout

JamesNK reviewed Apr 1, 2026

View reviewed changes

sebastienros and others added 5 commits March 31, 2026 18:19

Fix polyglot validation and CLI defaults

81b2570

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Revert unrelated CLI test changes

c2628dc

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move polyglot configs into language folders

f005775

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Make agent init E2E explicit

f3f54f1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Stabilize external service startup tests

722fcdd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JamesNK reviewed Apr 1, 2026

View reviewed changes

src/Aspire.Cli/Projects/LanguageDetectionPatternMatcher.cs Outdated Show resolved Hide resolved

JamesNK reviewed Apr 1, 2026

View reviewed changes

src/Aspire.Cli/Projects/LanguageDetectionPatternMatcher.cs Outdated Show resolved Hide resolved

sebastienros and others added 2 commits April 1, 2026 07:24

Revert non-sample refactor changes

2f8d743

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Revert unrelated branch changes

47cc90c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros requested review from adamint, danegsta and karolz-ms as code owners April 1, 2026 14:25

Restore polyglot config package dependencies

1dc8d0b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Keep Aspire.Hosting polyglot deps minimal

350a6fc

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge origin/main and move polyglot NuGet.config

b1fb150

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sebastienros merged commit dde17a7 into main Apr 1, 2026
258 checks passed

sebastienros deleted the sebros/polyglot-tests-layout branch April 1, 2026 16:37

eerhardt reviewed Apr 1, 2026

View reviewed changes

Conversation

sebastienros commented Mar 27, 2026

Description

Checklist

Uh oh!

github-actions bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JamesNK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastienros commented Apr 1, 2026

Uh oh!

sebastienros commented Apr 1, 2026

Uh oh!

Uh oh!

eerhardt Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Mar 27, 2026 •

edited

Loading